-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial configuration for translation platform #623
Conversation
#617 introduces new English strings to the PR which should be translated into other supported locales. |
🕐 This pull request has been open for some time now 🕐 It is important to merge it as soon as possible in order to avoid dealing with merge conflicts. More importantly the content in here really wants to reach production so everyone can benefit from it. 💚 |
2 similar comments
🕐 This pull request has been open for some time now 🕐 It is important to merge it as soon as possible in order to avoid dealing with merge conflicts. More importantly the content in here really wants to reach production so everyone can benefit from it. 💚 |
🕐 This pull request has been open for some time now 🕐 It is important to merge it as soon as possible in order to avoid dealing with merge conflicts. More importantly the content in here really wants to reach production so everyone can benefit from it. 💚 |
🕐 This pull request has been open for some time now 🕐 It is important to merge it as soon as possible in order to avoid dealing with merge conflicts. More importantly the content in here really wants to reach production so everyone can benefit from it. 💚 |
1 similar comment
🕐 This pull request has been open for some time now 🕐 It is important to merge it as soon as possible in order to avoid dealing with merge conflicts. More importantly the content in here really wants to reach production so everyone can benefit from it. 💚 |
translation.yml
Outdated
source_language: en | ||
target_languages: [de, es, fr, it, ja] | ||
components: | ||
- name: 'partner' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like the users are merchants, since all of the strings are merchant-facing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored the initial state of this file 👍
🕐 This pull request has been open for some time now 🕐 It is important to merge it as soon as possible in order to avoid dealing with merge conflicts. More importantly the content in here really wants to reach production so everyone can benefit from it. 💚 |
80f985a
to
9e4c9c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🕐 This pull request has been open for some time now 🕐 It is important to merge it as soon as possible in order to avoid dealing with merge conflicts. More importantly the content in here really wants to reach production so everyone can benefit from it. 💚 |
1 similar comment
🕐 This pull request has been open for some time now 🕐 It is important to merge it as soon as possible in order to avoid dealing with merge conflicts. More importantly the content in here really wants to reach production so everyone can benefit from it. 💚 |
9e4c9c3
to
39015dc
Compare
Owners:
Welcome to Shopify Translation Platform
This PR contains the configuration files required to have your source (English) strings sent for translation, and receive translations back into your repository.
Please review this PR before merging it!
translation.yml
cover all your source files.buyer
for end users of Shopify storesmerchant
where the users are merchantspartner
for Shopify partnersQuestions about this PR? Hop in the
#intl-services
Slack channel. We're happy to help!@Shopify/translation-platform